Rework the histogram activity chart #5685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rowanseymour
commented
Nov 22, 2024
•
rowanseymour
commented
- Max date is always today.
- Min date is at least 90 days in past.
- Bucket to months or weeks depending on how long we have data for.
rowanseymour
commented
Nov 22, 2024
| @@ -2888,9 +2887,6 @@ def test_results(self): | |||
| self.assertEqual("Color", counts[0]["name"]) | |||
| self.assertEqual(2, counts[0]["total"]) | |||
|
|
|||
| FlowCRUDL.ActivityChart.HISTOGRAM_MIN = 0 | |||
| FlowCRUDL.ActivityChart.PERIOD_MIN = 0 | |||
There was a problem hiding this comment.
these are always zero...
rowanseymour
commented
Nov 22, 2024
| @@ -1279,13 +1281,11 @@ def render_to_response(self, context, **response_kwargs): | |||
|
|
|||
| return JsonResponse( | |||
| { | |||
| "start_date": start_date, | |||
| "end_date": end_date, | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5685 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 571 571
Lines 25923 25920 -3
===========================================
- Hits 25923 25919 -4
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rowanseymour
force-pushed
the
rework_activity_charts
branch
from
984145c
to
59ccac8
Compare
rowanseymour
force-pushed
the
rework_activity_charts
branch
from
59ccac8
to
da88a3c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.